Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to pydantic2 (mixed versions) #6263

Closed
wants to merge 2 commits into from
Closed

Upgrade to pydantic2 (mixed versions) #6263

wants to merge 2 commits into from

Conversation

giancarloromeo
Copy link
Contributor

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo changed the title ⬆️ Upgrade to pydantic v2 ⬆️ Upgrade to pydantic 2 Aug 28, 2024
@giancarloromeo giancarloromeo changed the title ⬆️ Upgrade to pydantic 2 ⬆️ Upgrade to pydantic2 Aug 28, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.7%. Comparing base (cafbf96) to head (9d39614).
Report is 479 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6263      +/-   ##
=========================================
- Coverage    84.5%   81.7%    -2.8%     
=========================================
  Files          10     895     +885     
  Lines         214   37937   +37723     
  Branches       25    1398    +1373     
=========================================
+ Hits          181   31031   +30850     
- Misses         23    6704    +6681     
- Partials       10     202     +192
Flag Coverage Δ
integrationtests 59.5% <ø> (?)
unittests 82.1% <100.0%> (-2.4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ackages/aws-library/src/aws_library/ec2/_client.py 100.0% <100.0%> (ø)
...ackages/aws-library/src/aws_library/ec2/_models.py 89.4% <100.0%> (ø)
packages/aws-library/src/aws_library/s3/_client.py 96.7% <100.0%> (ø)
...kages/aws-library/src/aws_library/s3/_constants.py 100.0% <100.0%> (ø)
packages/aws-library/src/aws_library/s3/_errors.py 100.0% <100.0%> (ø)
packages/aws-library/src/aws_library/s3/_models.py 100.0% <100.0%> (ø)
packages/aws-library/src/aws_library/s3/_utils.py 100.0% <100.0%> (ø)
...ackages/aws-library/src/aws_library/ssm/_errors.py 100.0% <100.0%> (ø)
...dask_task_models_library/container_tasks/docker.py 100.0% <100.0%> (ø)
...dask_task_models_library/container_tasks/errors.py 100.0% <100.0%> (ø)
... and 127 more

... and 738 files with indirect coverage changes

@giancarloromeo giancarloromeo self-assigned this Aug 28, 2024
@giancarloromeo giancarloromeo added the t:maintenance Some planned maintenance work label Aug 28, 2024
@giancarloromeo giancarloromeo linked an issue Aug 28, 2024 that may be closed by this pull request
Major upgrade to pydantic 2.0 #4481
Open
@giancarloromeo giancarloromeo changed the title ⬆️ Upgrade to pydantic2 ⬆️ WIP: Upgrade to pydantic2 Aug 28, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarCloud

@giancarloromeo
Copy link
Contributor Author

FastAPI doesn't support a mix of pydantic version. The installed one determines the models version and so on.

See: fastapi/fastapi#10360

@giancarloromeo giancarloromeo changed the title ⬆️ WIP: Upgrade to pydantic2 Upgrade to pydantic2 (mixed versions) Aug 29, 2024
@giancarloromeo giancarloromeo deleted the is4481/upgrade-to-pydantic2 branch August 29, 2024 09:06
@giancarloromeo giancarloromeo removed a link to an issue Aug 29, 2024
Major upgrade to pydantic 2.0 #4481
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov will be requested when the pull request is marked ready for review pcrespov is a code owner

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg will be requested when the pull request is marked ready for review sanderegg is a code owner

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 will be requested when the pull request is marked ready for review matusdrobuliak66 is a code owner

@GitHK GitHK Awaiting requested review from GitHK GitHK will be requested when the pull request is marked ready for review GitHK is a code owner

Assignees

@giancarloromeo giancarloromeo

Labels
t:maintenance Some planned maintenance work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@giancarloromeo